Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: restoreccl: insert system.namespace entry for synthetic public schemas during restore #74759

Merged
merged 2 commits into from
Jan 21, 2022
Merged

release-21.2: restoreccl: insert system.namespace entry for synthetic public schemas during restore #74759

merged 2 commits into from
Jan 21, 2022

Conversation

RichardJCai
Copy link
Contributor

Backport 1/1 commits from #73875.

/cc @cockroachdb/release

Release note (bug fix): Previously during restore we wouldn't insert a system.namespace
entry for synthetic public schemas.

Resolves #73535

@RichardJCai RichardJCai requested review from dt and a team January 12, 2022 19:37
@blathers-crl
Copy link

blathers-crl bot commented Jan 12, 2022 •
edited by RichardJCai
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RichardJCai
restoreccl: insert system.namespace entry for synthetic public schema…
d336636 
…s during restore

Release note (bug fix): Previously during restore we wouldn't insert a system.namespace
entry for synthetic public schemas.
@RichardJCai RichardJCai force-pushed the backport21.2-73875 branch 2 times, most recently from f2c91c2 to c17de1c Compare January 19, 2022 18:25
adityamaru
adityamaru approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo CI failures

@RichardJCai
backupccl: delete public namespace entry on database restore failure
d2c89fe 
Release note: None (Issue not yet in live release)
@RichardJCai RichardJCai merged commit 9b6a40f into cockroachdb:release-21.2 Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru approved these changes

@dt dt Awaiting requested review from dt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardJCai @cockroach-teamcity @adityamaru